Require reference ranges for published question labs

2026-07-29 01:28:37 -05:00
parent f082be38e0
commit c14ac1d65b
3 changed files with 289 additions and 0 deletions
@@ -68,11 +68,31 @@ public static class QuestionValidator
        if (string.IsNullOrWhiteSpace(req.System)) return "system required";
        if (string.IsNullOrWhiteSpace(req.Discipline)) return "discipline required";
        if (req.Difficulty is < 1 or > 5) return "difficulty must be between 1 and 5";
+        var labValidation = ValidateLabs(req.Labs, req.IsPublished);
+        if (labValidation is not null) return labValidation;
        var referenceValidation = ValidateReferences(req.References, req.IsPublished);
        if (referenceValidation is not null) return referenceValidation;
        return null;
    }

+    public static string? ValidateLabs(IReadOnlyCollection<QuestionLab>? labs, bool requireComplete)
+    {
+        if (labs is null)
+            return "labs must be an array";
+        if (labs.Count > 50)
+            return "questions support at most fifty lab results";
+
+        foreach (var lab in labs)
+        {
+            if (string.IsNullOrWhiteSpace(lab.Name) || string.IsNullOrWhiteSpace(lab.Value))
+                return "lab name and value are required";
+            if (requireComplete && string.IsNullOrWhiteSpace(lab.Reference))
+                return $"published question lab '{lab.Name.Trim()}' requires a reference range";
+        }
+
+        return null;
+    }
+
    public static string? ValidateReferences(IReadOnlyCollection<QuestionReference>? references, bool required)
    {
        if (references is null)