Make simulation block submission idempotent

api/QuestionsApi.Tests/ExamSimulationTests.cs

@@ -111,6 +111,16 @@ public sealed class ExamSimulationTests
         Assert.False(ExamSimulationStore.TryDecodeHistoryCursor("not-a-cursor", out _));
     }
 
+    [Theory]
+    [InlineData(ExamSimulationStates.BetweenBlocks, true)]
+    [InlineData(ExamSimulationStates.Completed, true)]
+    [InlineData(ExamSimulationStates.BlockActive, false)]
+    [InlineData(ExamSimulationStates.Abandoned, false)]
+    public void RepeatedBlockSubmissionIsIdempotentOnlyAfterSubmission(string state, bool expected)
+    {
+        Assert.Equal(expected, ExamSimulationStore.IsAlreadySubmittedState(state));
+    }
+
     private static List<ExamSimulationItem> BuildItems(int count, bool wasSeen = false) =>
         Enumerable.Range(0, count).Select(index => new ExamSimulationItem
         {

api/QuestionsApi/Services/ExamSimulationStore.cs

@@ -354,6 +354,8 @@ public class ExamSimulationStore
 
     public async Task<ExamSimulation> SubmitBlockAsync(ExamSimulation simulation, bool expired = false)
     {
+        if (IsAlreadySubmittedState(simulation.State))
+            return simulation;
         if (simulation.State != ExamSimulationStates.BlockActive)
             throw new InvalidOperationException("There is no active block to submit.");
         if (!expired && simulation.BlockDeadlineUtc is not null)
@@ -370,6 +372,9 @@ public class ExamSimulationStore
         return simulation;
     }
 
+    public static bool IsAlreadySubmittedState(string state) =>
+        state is ExamSimulationStates.BetweenBlocks or ExamSimulationStates.Completed;
+
     public async Task AbandonAsync(ExamSimulation simulation)
     {
         simulation.State = ExamSimulationStates.Abandoned;