hz/step3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Lock submitted simulation answers

Browse Source
This commit is contained in:
hz
2026-07-30 16:54:12 -05:00
parent 9709bab9a9
commit 5488dec2c7
8 changed files with 142 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/post_answer_review_test.gd
+14
View File
@@ -426,6 +426,20 @@ func _test_player_runtime_construction() -> void:
_assert(player.choice_buttons[0].size.x <= player.question_panel.size.x, "long answer choices should not widen the question player")
_assert(player.next_button.get_global_rect().end.x <= player.get_global_rect().end.x + 0.5, "long answer choices should never push Submit beyond the viewport")
var prior_session_kind: String = root.get_node("BlockSessionService").session_kind
_assert(root.get_node("BlockSessionService")._simulation_response_is_submitted({"choiceId": "A", "isSubmitted": null}), "legacy answered simulation responses should restore as submitted")
_assert(not root.get_node("BlockSessionService")._simulation_response_is_submitted({"choiceId": "A", "isSubmitted": false}), "new simulation drafts should remain editable after an in-session autosave")
_assert(not root.get_node("BlockSessionService")._simulation_response_is_submitted({"choiceId": "", "isSubmitted": null}), "legacy skipped simulation responses should remain revisitable")
root.get_node("BlockSessionService").session_kind = "simulation"
player.presented_choices = [{"id": "A", "text": "First"}, {"id": "B", "text": "Second"}]
player.current_answer = {"selected_choice_id": "A", "is_submitted": true}
player.selected_choice = "A"
player._apply_saved_choice_state()
_assert(player.choice_buttons[0].disabled and player.choice_buttons[1].disabled, "resumed submitted simulation answers should lock every choice")
_assert(not player.next_button.disabled, "a resumed submitted answer should still allow navigation to the next question")
player._select_choice(1)
_assert(player.selected_choice == "A", "a resumed submitted simulation answer should not be changeable")
player.current_answer = {}
player.selected_choice = ""
for session_kind in ["block", "core", "bookmark", "review", "simulation"]:
root.get_node("BlockSessionService").session_kind = session_kind
player._refresh_toolbar_state()
tests/simulation_history_ui_test.gd
+7
View File
@@ -19,6 +19,13 @@ func _run() -> void:
service.simulation["state"] = "completed"
_assert(service._is_stale_submit_failure("submit"), "a submit failure after completion should be ignored")
_assert(not service._is_stale_submit_failure("save"), "non-submit failures should still be surfaced")
service.simulation["state"] = "block_active"
service.submit_recovery_attempts = 0
_assert(service._should_reconcile_submit_failure("submit", 409), "an active-block submit conflict should reconcile automatically")
service.submit_recovery_attempts = 1
_assert(not service._should_reconcile_submit_failure("submit", 409), "submit conflict recovery should be bounded")
_assert(not service._should_reconcile_submit_failure("submit", 500), "non-conflict submit failures should still be surfaced")
service.submit_recovery_attempts = 0
service.simulation["state"] = "between_blocks"
var host := Control.new()
host.size = Vector2(1400, 800)