diff --git a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Action/ActionCreditCardImportService.cs b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Action/ActionCreditCardImportService.cs index 1624249..067bd75 100644 --- a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Action/ActionCreditCardImportService.cs +++ b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Action/ActionCreditCardImportService.cs @@ -10,7 +10,6 @@ using LCU.API.Internal.Operations.IncentiveApi.Services.MicroApiServices; using LCU.Library.Internal.IncentiveApiModels.Requests; using LCU.API.Internal.Operations.IncentiveApi.Services.Transformations; using LCU.Library.Internal.ApiResponse.Services; -using LCU.Library.Internal.Exceptions; using LCU.Library.Internal.IncentiveApiModels.Results; namespace LCU.API.Internal.Operations.IncentiveApi.Services.Action; @@ -52,7 +51,6 @@ public class ActionCreditCardImportService : IActionCreditCardImportService _actionCreditCardResult.MessageStack.Add(message); _actionCreditCardResult.Success = false; await QueueReturnResponse.QueueResponse(request, _actionCreditCardResult.Success, _actionCreditCardResult.MessageStack); - throw new ServiceException(message); } } diff --git a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Action/ActionVehicleImportService.cs b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Action/ActionVehicleImportService.cs index cf9734b..2beb170 100644 --- a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Action/ActionVehicleImportService.cs +++ b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Action/ActionVehicleImportService.cs @@ -11,7 +11,6 @@ using LCU.Library.Internal.IncentiveApiModels.Requests; using LCU.API.Internal.Operations.IncentiveApi.Services.Transformations; using LCU.Library.Internal.IncentiveApiModels.Results; using LCU.Library.Internal.ApiResponse.Services; -using LCU.Library.Internal.Exceptions; namespace LCU.API.Internal.Operations.IncentiveApi.Services.Action; @@ -49,7 +48,6 @@ public class ActionVehicleImportService : IActionVehicleImportService _actionVehicleProcessResult.MessageStack.Add(message); _actionVehicleProcessResult.Success = false; await QueueReturnResponse.QueueResponse(request, _actionVehicleProcessResult.Success, _actionVehicleProcessResult.MessageStack); - throw new ServiceException(message); } } diff --git a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Allied/AlliedGapMbpTransactionImportService.cs b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Allied/AlliedGapMbpTransactionImportService.cs index 3303389..609fa77 100644 --- a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Allied/AlliedGapMbpTransactionImportService.cs +++ b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Allied/AlliedGapMbpTransactionImportService.cs @@ -14,7 +14,6 @@ using LCU.Library.Internal.IncentiveApiModels.Requests; using LCU.API.Internal.Operations.IncentiveApi.Services.MicroApiServices; using LCU.API.Internal.Operations.IncentiveApi.Services.Transformations; using LCU.Library.Internal.ApiResponse.Services; -using LCU.Library.Internal.Exceptions; using LCU.Library.Internal.IncentiveApiModels.Results; namespace LCU.API.Internal.Operations.IncentiveApi.Services.Allied; @@ -69,7 +68,6 @@ public class AlliedGapMbpTransactionImportService : IAlliedGapMbpTransactionImpo _alliedGapMbpProcessResult.MessageStack.Add(message); _alliedGapMbpProcessResult.Success = false; await QueueReturnResponse.QueueResponse(request, _alliedGapMbpProcessResult.Success, _alliedGapMbpProcessResult.MessageStack); - throw new ServiceException(message); } } diff --git a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/AutoDecision/ActivityDecisionService.cs b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/AutoDecision/ActivityDecisionService.cs index 6066a7d..67553f9 100644 --- a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/AutoDecision/ActivityDecisionService.cs +++ b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/AutoDecision/ActivityDecisionService.cs @@ -6,7 +6,6 @@ using LCU.Library.Internal.IncentiveApiModels.Common; using LCU.Library.Internal.IncentiveApiModels.Requests; using LCU.Library.Internal.IncentiveApiModels.Results; using LCU.Library.Internal.ApiResponse.Services; -using LCU.Library.Internal.Exceptions; namespace LCU.API.Internal.Operations.IncentiveApi.Services.AutoDecision; @@ -69,7 +68,6 @@ public class ActivityDecisionService : IActivityDecisionService _incentiveProcessResult.MessageStack.Add(message); _incentiveProcessResult.Success = false; await QueueReturnResponse.QueueResponse(request, _incentiveProcessResult.Success, _incentiveProcessResult.MessageStack); - throw new ServiceException(message); } } diff --git a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Dayforce/DayForceSyncService.cs b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Dayforce/DayForceSyncService.cs index 2ff0480..1dda635 100644 --- a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Dayforce/DayForceSyncService.cs +++ b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Dayforce/DayForceSyncService.cs @@ -8,7 +8,6 @@ using LCU.API.Internal.Operations.IncentiveApi.Services.MicroApiServices; using LCU.API.Internal.Operations.IncentiveApi.Configuration; using LCU.Library.Internal.IncentiveApiModels.Requests; using LCU.Library.Internal.ApiResponse.Services; -using LCU.Library.Internal.Exceptions; using ProcessResult = LCU.Library.Internal.IncentiveApiModels.Results.ProcessResult; namespace LCU.API.Internal.Operations.IncentiveApi.Services.Dayforce; @@ -78,7 +77,6 @@ public class DayForceSyncService : IDayForceSyncService _dayforceSyncProcessResult.MessageStack.Add(message); _dayforceSyncProcessResult.Success = false; await QueueReturnResponse.QueueResponse(request, _dayforceSyncProcessResult.Success, _dayforceSyncProcessResult.MessageStack); - throw new ServiceException(message); } } diff --git a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/DnaActivitySyncService.cs b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/DnaActivitySyncService.cs index 6da40f3..0c3d29f 100644 --- a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/DnaActivitySyncService.cs +++ b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/DnaActivitySyncService.cs @@ -3,7 +3,6 @@ using LCU.Library.Internal.IncentiveApiModels.Results; using LCU.Library.Internal.LCUServiceFactory.Services; using LCU.API.Internal.Operations.IncentiveApi.Services.IncentiveProcesses; using LCU.Library.Internal.ApiResponse.Services; -using LCU.Library.Internal.Exceptions; namespace LCU.API.Internal.Operations.IncentiveApi.Services; @@ -36,11 +35,11 @@ public class DnaActivitySyncService : IDnaActivitySyncService } catch (Exception exception) { - var message = $"There was an issue with {request.IncentiveProcessType}. Exception Message: {exception.Message}."; + var processType = request?.IncentiveProcessType.ToString() ?? "unknown incentive process"; + var message = $"There was an issue with {processType}. Exception Message: {exception.Message}."; _incentiveProcessResult.MessageStack.Add(message); _incentiveProcessResult.Success = false; await QueueReturnResponse.QueueResponse(request, _incentiveProcessResult.Success, _incentiveProcessResult.MessageStack); - throw new ServiceException(message); } } diff --git a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/GoalDispersalService.cs b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/GoalDispersalService.cs index 5736083..00c9a96 100644 --- a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/GoalDispersalService.cs +++ b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/GoalDispersalService.cs @@ -5,7 +5,6 @@ using LCU.API.Internal.Operations.IncentiveApiLib.Repositories; using LCU.Library.Internal.IncentiveApiModels.Requests; using LCU.API.Internal.Operations.IncentiveApi.Services.MicroApiServices; using LCU.Library.Internal.ApiResponse.Services; -using LCU.Library.Internal.Exceptions; using LCU.Library.Internal.IncentiveApiModels.Results; namespace LCU.API.Internal.Operations.IncentiveApi.Services; @@ -162,11 +161,13 @@ public class GoalDispersalService : IGoalDispersalService catch (Exception exception) { Log.Fatal(exception, "There was an Unhandled error Executing Month Start Dispersal"); - var message = $"There was an issue with handling the Goal Dispersal Service Process {request.StartDate.Month}{request.StartDate.Year}. Exception Message: {exception.Message}."; + var processLabel = request == null + ? "unknown" + : $"{request.StartDate.Month}{request.StartDate.Year}"; + var message = $"There was an issue with handling the Goal Dispersal Service Process {processLabel}. Exception Message: {exception.Message}."; _goalDispersalProcessResult.MessageStack.Add(message); _goalDispersalProcessResult.Success = false; await QueueReturnResponse.QueueResponse(request, _goalDispersalProcessResult.Success, _goalDispersalProcessResult.MessageStack); - throw new ServiceException(message); } } diff --git a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/NightlyDecisionServices/NightlyActivityDecisionService.cs b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/NightlyDecisionServices/NightlyActivityDecisionService.cs index 7b95e86..4b7271c 100644 --- a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/NightlyDecisionServices/NightlyActivityDecisionService.cs +++ b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/NightlyDecisionServices/NightlyActivityDecisionService.cs @@ -3,7 +3,6 @@ using LCU.Library.Internal.IncentiveApiModels.Results; using LCU.Library.Internal.LCUServiceFactory.Services; using LCU.API.Internal.Operations.IncentiveApi.Services.NightlyIncentiveProcesses; using LCU.Library.Internal.ApiResponse.Services; -using LCU.Library.Internal.Exceptions; namespace LCU.API.Internal.Operations.IncentiveApi.Services.NightlyDecisionServices; @@ -40,7 +39,6 @@ public class NightlyActivityDecisionService : INightlyActivityDecisionService _processResult.MessageStack.Add(message); _processResult.Success = false; await QueueReturnResponse.QueueResponse(request, _processResult.Success, _processResult.MessageStack); - throw new ServiceException(message); } } } diff --git a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Payout/PayoutService.cs b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Payout/PayoutService.cs index 3af8ec9..126b3d1 100644 --- a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Payout/PayoutService.cs +++ b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Payout/PayoutService.cs @@ -5,7 +5,6 @@ using LCU.Library.Internal.IncentiveApiModels.Entities; using LCU.Library.Internal.IncentiveApiModels.Common; using LCU.Library.Internal.IncentiveApiModels.Requests; using LCU.Library.Internal.ApiResponse.Services; -using LCU.Library.Internal.Exceptions; using ProcessResult = LCU.Library.Internal.IncentiveApiModels.Results.ProcessResult; namespace LCU.API.Internal.Operations.IncentiveApi.Services.Payout; @@ -46,11 +45,11 @@ public class PayoutService : IPayoutService catch (Exception exception) { Log.Fatal(exception, "There was an Unhandled error with Monthly Incentive Payout Process"); - var message = $"There was an Unhandled error with Monthly Incentive Payout Process from {request.MonthsBack} months back from today's date. Exception Message: {exception.Message}."; + var monthsBack = request?.MonthsBack.ToString() ?? "unknown"; + var message = $"There was an Unhandled error with Monthly Incentive Payout Process from {monthsBack} months back from today's date. Exception Message: {exception.Message}."; _payoutIncentiveProcessResult.MessageStack.Add(message); _payoutIncentiveProcessResult.Success = false; await QueueReturnResponse.QueueResponse(request, _payoutIncentiveProcessResult.Success, _payoutIncentiveProcessResult.MessageStack); - throw new ServiceException(message); } } diff --git a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Reporting/ReportingService.cs b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Reporting/ReportingService.cs index 3375444..4add508 100644 --- a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Reporting/ReportingService.cs +++ b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Reporting/ReportingService.cs @@ -4,7 +4,6 @@ using LCU.Library.Internal.IncentiveApiModels.Common; using LCU.Library.Internal.IncentiveApiModels.Requests; using LCU.Library.Internal.IncentiveApiModels.Results; using LCU.Library.Internal.ApiResponse.Services; -using LCU.Library.Internal.Exceptions; namespace LCU.API.Internal.Operations.IncentiveApi.Services.Reporting; @@ -40,7 +39,6 @@ public class ReportingService : IReportingService _reportingProcessResult.MessageStack.Add(message); _reportingProcessResult.Success = false; await QueueReturnResponse.QueueResponse(request, _reportingProcessResult.Success, _reportingProcessResult.MessageStack); - throw new ServiceException(message); } } } diff --git a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Temenos/ImportCreditCardSalesService.cs b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Temenos/ImportCreditCardSalesService.cs index f7a2503..5a901b7 100644 --- a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Temenos/ImportCreditCardSalesService.cs +++ b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Temenos/ImportCreditCardSalesService.cs @@ -59,7 +59,6 @@ public class ImportCreditCardSalesService : IImportCreditCardSalesService _importCreditCardResult.MessageStack.Add(message); _importCreditCardResult.Success = false; await QueueReturnResponse.QueueResponse(request, _importCreditCardResult.Success, _importCreditCardResult.MessageStack); - throw new ServiceException(message); } } diff --git a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Temenos/ImportIndirectVehicleSalesService.cs b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Temenos/ImportIndirectVehicleSalesService.cs index f83eeba..d179d04 100644 --- a/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Temenos/ImportIndirectVehicleSalesService.cs +++ b/LCU.API.Operations.IncentiveAPI/LCU.API.Internal.Operations.IncentiveApi/Services/Temenos/ImportIndirectVehicleSalesService.cs @@ -48,7 +48,6 @@ public class ImportIndirectVehicleSalesService : IImportIndirectVehicleSalesServ _importIndirectVehicleSalesResult.MessageStack.Add(message); _importIndirectVehicleSalesResult.Success = false; await QueueReturnResponse.QueueResponse(request, _importIndirectVehicleSalesResult.Success, _importIndirectVehicleSalesResult.MessageStack); - throw new ServiceException(message); } }