Fixing 500 error when entering a bad itemid when creating an auction

2025-06-05 09:44:04 -05:00
parent ea25e3b63d
commit a88e50d111
3 changed files with 42 additions and 2 deletions
@@ -20,8 +20,13 @@ public class AuctionService
    public virtual async Task CreateAsync(Auction auction) =>
        await _auctions.InsertOneAsync(auction);

-    public virtual async Task<Auction> GetByIdAsync(string id) =>
-        await _auctions.Find(a => a.Id == id).FirstOrDefaultAsync();
+    public virtual async Task<Auction> GetByIdAsync(string id)
+    {
+        if (!MongoDB.Bson.ObjectId.TryParse(id, out _))
+            return null;
+
+        return await _auctions.Find(a => a.Id == id).FirstOrDefaultAsync();
+    }

    public virtual async Task UpdateAsync(Auction auction) =>
        await _auctions.ReplaceOneAsync(a => a.Id == auction.Id, auction);